feat(semester_process): add the duplication of the mission relation logic and...

feat(semester_process): add the duplication of the mission relation logic and validation into a concern

app/models/concerns/mission_either_one_relation.rb

+module MissionEitherOneRelation
+  extend ActiveSupport::Concern
+
+  included do
+    # relates to either Assignment or GroupAssignment (not GroupOffer!)
+    belongs_to :assignment, optional: true
+    belongs_to :group_assignment, optional: true
+
+    validate :validate_group_assignment_or_assignment_present
+
+    def mission=(mission)
+      if mission.class.name == 'Assignment'
+        self.assignment = mission
+      else
+        self.group_assignment = mission
+      end
+    end
+
+    def mission
+      group_assignment || assignment
+    end
+
+    private
+
+    def validate_group_assignment_or_assignment_present
+      errors.add(:association_insuficient) if assignment.blank? && group_assignment.blank?
+    end
+  end
+end

app/models/semester_feedback.rb

 class SemesterFeedback < ApplicationRecord
+  include MissionEitherOneRelation
+
   belongs_to :author, -> { with_deleted }, class_name: 'User', inverse_of: 'semester_feedbacks'
   belongs_to :semester_process_volunteer
   has_one :semester_process, through: :semester_process_volunteer
   has_one :volunteer, through: :semester_process_volunteer
-
-  # relates to either Assignment or GroupAssignment (not GroupOffer!)
-  belongs_to :assignment, optional: true
-  belongs_to :group_assignment, optional: true
-
-  validate :validate_group_assignment_or_assignment_present
-
-  def mission=(mission)
-    if mission.class.name == 'Assignment'
-      self.assignment = mission
-    else
-      self.group_assignment = mission
-    end
-  end
-
-  def mission
-    group_assignment || assignment
-  end
-
-  private
-
-  def validate_group_assignment_or_assignment_present
-    errors.add(:association_insuficient) if assignment.blank? && group_assignment.blank?
-  end
 end

app/models/semester_process_volunteer_mission.rb

 class SemesterProcessVolunteerMission < ApplicationRecord
-  belongs_to :semester_process_volunteer
-
-  # relates to either Assignment or GroupAssignment (not GroupOffer!)
-  belongs_to :assignment, optional: true
-  belongs_to :group_assignment, optional: true
-
-  validate :validate_group_assignment_or_assignment_present
-
-  def mission=(mission)
-    if mission.class.name == 'Assignment'
-      self.assignment = mission
-    else
-      self.group_assignment = mission
-    end
-  end
+  include MissionEitherOneRelation
 
-  def mission
-    group_assignment || assignment
-  end
-
-  private
-
-  def validate_group_assignment_or_assignment_present
-    errors.add(:association_insuficient) if assignment.blank? && group_assignment.blank?
-  end
+  belongs_to :semester_process_volunteer
 end