Verified Commit 78670a7f authored by Kaspar Vollenweider's avatar Kaspar Vollenweider
Browse files

chore(linting): non todo fix Metrics/BlockLength cop

parent 3142fd93
......@@ -7,14 +7,14 @@ require:
AllCops:
Exclude:
- 'db/schema.rb'
- 'db/migrate/*'
- 'bin/*'
- 'tmp/**/*'
- 'db/migrate/*'
- 'db/schema.rb'
- 'doc/**/*'
- vendor/**/*
- Rakefile
- 'tmp/**/*'
- config/boot.rb
- Rakefile
- vendor/**/*
DisplayCopNames: true
DisplayStyleGuide: true
ExtraDetails: true
......@@ -55,19 +55,19 @@ Metrics/AbcSize:
- lib/access_import/**/*
- test/**/*
IgnoredMethods:
- dates_semester_start
- boolean_toggler_filter_dropdown
- build_nested_objects
- custom_filter_dropdown_filters
- td_truncate_content_modal
- validate_group_assignment_or_assignment_present
- dates_semester_start
- document_js_nodes
- take_responsibility
- build_nested_objects
- handle_semester_feedback_quote
- set_journaled
- in_feedbackable?
- last_submitted_hours_and_feedbacks
- selected_billing_semester
- in_feedbackable?
- set_journaled
- take_responsibility
- td_truncate_content_modal
- validate_group_assignment_or_assignment_present
Metrics/ClassLength:
Exclude:
......@@ -75,19 +75,27 @@ Metrics/ClassLength:
Max: 150
Metrics/MethodLength:
Exclude:
- test/**/*
- db/seeds.rb
Max: 20
ExcludedMethods:
- update_or_create
- document_js_nodes
- volunteers_stats
- create_all_assignments
- create_semester_processes
- setup
Metrics/BlockLength:
Exclude:
- 'test/system/*'
- 'db/seeds.rb'
- 'config/routes.rb'
- '**/*.xlsx.axlsx'
- config/initializers/**/*
- db/seeds.rb
- lib/tasks/**/*
- test/system/terminate_volunteers_test.rb
ExcludedMethods:
- included # for concerns
- draw # for routes
- define # for FactoryBot
- draw # for routes
- factory
- included # for concerns
- test
Lint/RaiseException:
......
......@@ -307,24 +307,6 @@ Lint/Void:
- 'config/initializers/countries.rb'
# Offense count: 14
# Configuration parameters: CountComments, Max, ExcludedMethods.
# ExcludedMethods: refine
Metrics/BlockLength:
Exclude:
- 'test/system/*'
- 'db/seeds.rb'
- 'config/routes.rb'
- 'app/views/assignments/_assignments_table.xlsx.axlsx'
- 'app/views/clients/_client_table.xlsx.axlsx'
- 'app/views/events/show.xlsx.axlsx'
- 'app/views/group_offers/index.xlsx.axlsx'
- 'app/views/users/index.xlsx.axlsx'
- 'app/views/volunteers/index.xlsx.axlsx'
- 'config/initializers/simple_form_bootstrap.rb'
- 'lib/tasks/access.rake'
- 'lib/tasks/setup.rake'
# Offense count: 4
# Configuration parameters: CountComments, Max.
Metrics/ClassLength:
......@@ -348,13 +330,13 @@ Metrics/CyclomaticComplexity:
# Offense count: 3
# Configuration parameters: CountComments, Max, ExcludedMethods.
Metrics/MethodLength:
Exclude:
- 'test/**/*'
- 'db/seeds.rb'
- 'app/controllers/semester_processes_controller.rb'
- 'app/models/document_treeview.rb'
- 'app/models/performance_report.rb'
# Metrics/MethodLength:
# Exclude:
# - 'test/**/*'
# - 'db/seeds.rb'
# - 'app/controllers/semester_processes_controller.rb'
# - 'app/models/document_treeview.rb'
# - 'app/models/performance_report.rb'
# Offense count: 2
# Configuration parameters: CountComments, Max.
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment