Skip to content
GitLab
Menu
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
Menu
Open sidebar
open-source
aoz-003
Commits
b23208c7
Verified
Commit
b23208c7
authored
Jul 06, 2018
by
Kaspar Vollenweider
👻
Browse files
rename Angeschaut to Quittiert and feedback redirect back also respects page parameter
parent
58421bdb
Changes
2
Hide whitespace changes
Inline
Side-by-side
app/controllers/feedbacks_controller.rb
View file @
b23208c7
...
...
@@ -3,6 +3,8 @@ class FeedbacksController < ApplicationController
only:
[
:show
,
:edit
,
:update
,
:destroy
,
:mark_as_done
,
:take_responsibility
]
before_action
:set_feedbackable
before_action
:set_volunteer
before_action
:set_list_response_feedback_redirect_back_path
,
only:
[
:mark_as_done
,
:take_responsibility
]
def
index
authorize
Feedback
...
...
@@ -49,11 +51,11 @@ class FeedbacksController < ApplicationController
end
def
mark_as_done
redirect_path
=
list_responses_feedbacks_path
(
params
.
to_unsafe_hash
.
slice
(
:q
))
if
@feedback
.
update
(
reviewer:
current_user
)
redirect_to
(
redirect_path
,
notice:
'Halbjahres-Rapport quittiert.'
)
redirect_to
(
@
redirect_
back_
path
,
notice:
'Halbjahres-Rapport quittiert.'
)
else
redirect_to
(
redirect_path
,
notice:
'Fehler: Quittieren fehlgeschlagen.'
)
redirect_to
(
@redirect_back_path
,
notice:
'Fehler: Quittieren fehlgeschlagen.'
)
end
end
def
take_responsibility
...
...
@@ -65,6 +67,13 @@ class FeedbacksController < ApplicationController
end
private
def
set_list_response_feedback_redirect_back_path
@redirect_back_path
=
list_responses_feedbacks_path
(
params
.
to_unsafe_hash
.
slice
(
:q
,
:page
)
)
end
def
simple_form_params
@simple_form_for_params
=
[
[
@volunteer
,
@feedbackable
,
@feedback
],
{
...
...
app/views/list_responses/feedbacks.html.slim
View file @
b23208c7
...
...
@@ -6,8 +6,8 @@ nav.navbar.section-navigation.hidden-print
ul
.list-inline
li
=
clear_filter_button
=
custom_filter_dropdown
(
'Geprüft'
,
{
q: :reviewer_id_not_null
,
text:
'
Angeschau
t'
,
value:
'true'
},
{
q: :reviewer_id_null
,
text:
'Un
gesehen
'
,
value:
'true'
})
{
q: :reviewer_id_not_null
,
text:
'
Quittier
t'
,
value:
'true'
},
{
q: :reviewer_id_null
,
text:
'Un
quittiert
'
,
value:
'true'
})
=
custom_filter_dropdown
(
'Übernommen'
,
{
q: :responsible_id_null
,
text:
'Offen'
,
value:
'true'
},
{
q: :responsible_id_not_null
,
text:
'Übernommen'
,
value:
'true'
},
...
...
@@ -60,9 +60,7 @@ table.table.table-striped.list-responses-table
td
.index-action-cell
span
=
I18n
.
l
record
.
created_at
.
to_date
-
if
record
.
reviewer
.
present?
span
=
"Angeschaut von: "
=
link_to
record
.
reviewer
.
email
,
record
.
reviewer
span
Quittiert
von:
#{
link_to
(
record
.
reviewer
.
email
,
record
.
reviewer
)
}
td
.index-action-cell.hidden-print
-
if
record
.
responsible
.
present?
=
'Übernommen durch '
...
...
@@ -76,7 +74,9 @@ table.table.table-striped.list-responses-table
-
if
record
.
reviewer
.
present?
=
link_to
'Anzeigen'
,
polymorphic_path
([
record
.
volunteer
,
record
.
feedbackable
,
record
])
-
else
=
link_to
'Angeschaut'
,
polymorphic_path
([
record
.
volunteer
,
record
.
feedbackable
,
record
],
action: :mark_as_done
,
q:
search_parameters
),
{
method: :put
,
class:
'btn btn-default btn-xs m-t-10'
}
=
link_to
'Quittieren'
,
polymorphic_path
([
record
.
volunteer
,
record
.
feedbackable
,
record
],
action: :mark_as_done
,
q:
search_parameters
),
{
method: :put
,
class:
'btn btn-default btn-xs m-t-10'
}
=
bootstrap_paginate
(
@feedbacks
)
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment