aoz-003 merge requestshttps://git.panter.ch/open-source/aoz-003/-/merge_requests2018-01-19T11:13:24+01:00https://git.panter.ch/open-source/aoz-003/-/merge_requests/436Fixes: Group Offers and Department Manager2018-01-19T11:13:24+01:00Ghost UserFixes: Group Offers and Department ManagerStory in [trello](https://trello.com/c/XJBStWLo/40-bugfix-if-the-department-manager-who-is-responsible-for-a-group-offer-has-no-department-they-cannot-edit-view-their-group-offer)
If the department manager who is responsible for a gro...Story in [trello](https://trello.com/c/XJBStWLo/40-bugfix-if-the-department-manager-who-is-responsible-for-a-group-offer-has-no-department-they-cannot-edit-view-their-group-offer)
If the department manager who is responsible for a group offer has no department, they cannot edit/view their group offerhttps://git.panter.ch/open-source/aoz-003/-/merge_requests/707Fix bug in GroupAssignmentPolicy2018-05-17T11:11:34+02:00Markus Kollermarkus-koller@gmx.chFix bug in GroupAssignmentPolicyPart of [this story](https://trello.com/c/W8R8Nljd/246-dont-show-beendete-eins%C3%A4tze-button-for-department-manager) (which isn't fully defined yet)
Fixes `/group_assignments/terminated_index` when logged in as department manager.Part of [this story](https://trello.com/c/W8R8Nljd/246-dont-show-beendete-eins%C3%A4tze-button-for-department-manager) (which isn't fully defined yet)
Fixes `/group_assignments/terminated_index` when logged in as department manager.https://git.panter.ch/open-source/aoz-003/-/merge_requests/663Handle terminated assignments without hours2018-05-11T14:47:29+02:00Markus Kollermarkus-koller@gmx.chHandle terminated assignments without hourshttps://trello.com/c/s9EYxklq/176-expection-on-termination
I'm assuming assignments can be terminated even if they don't have any feedback or hours. Should we still display the empty table?
![Selection_001](/uploads/356dd3aa28c9ba...https://trello.com/c/s9EYxklq/176-expection-on-termination
I'm assuming assignments can be terminated even if they don't have any feedback or hours. Should we still display the empty table?
![Selection_001](/uploads/356dd3aa28c9bace99e2308535f67cf9/Selection_001.png)https://git.panter.ch/open-source/aoz-003/-/merge_requests/649Open link in new tab2018-05-07T15:29:29+02:00Markus Kollermarkus-koller@gmx.chOpen link in new tabhttps://trello.com/c/wyYyVeme/141-click-on-the-link-on-volunteer-signup-should-open-new-tab-not-the-warning-dialoghttps://trello.com/c/wyYyVeme/141-click-on-the-link-on-volunteer-signup-should-open-new-tab-not-the-warning-dialoghttps://git.panter.ch/open-source/aoz-003/-/merge_requests/648Fix billing_expenses#index for volunteers2018-05-08T11:38:00+02:00Markus Kollermarkus-koller@gmx.chFix billing_expenses#index for volunteershttps://trello.com/c/Lc7IbSmO/86-1h-show-expenses-and-hours-for-one-volunteerhttps://trello.com/c/Lc7IbSmO/86-1h-show-expenses-and-hours-for-one-volunteerhttps://git.panter.ch/open-source/aoz-003/-/merge_requests/647Fix assignment policies2018-05-09T14:01:28+02:00Markus Kollermarkus-koller@gmx.chFix assignment policieshttps://trello.com/c/JLlzeS69/157-bug-as-volunteer-i-should-not-be-able-to-edit-assignementshttps://trello.com/c/JLlzeS69/157-bug-as-volunteer-i-should-not-be-able-to-edit-assignementshttps://git.panter.ch/open-source/aoz-003/-/merge_requests/638Return to stored location after login2018-05-08T13:52:31+02:00Markus Kollermarkus-koller@gmx.chReturn to stored location after loginhttps://trello.com/c/QkSDipON/124-1h-redirect-to-lastsubmittedhours-after-login-from-emailhttps://trello.com/c/QkSDipON/124-1h-redirect-to-lastsubmittedhours-after-login-from-emailhttps://git.panter.ch/open-source/aoz-003/-/merge_requests/451Bugfix/group offer category filter shows id instead of group offer category name2018-01-23T15:31:04+01:00Kaspar Vollenweidervok@panter.chBugfix/group offer category filter shows id instead of group offer category name[Trello Story](https://trello.com/c/z2zOvXD5/53-bugfix-groupoffer-index-groupoffercategory-filter-shows-id-instead-of-categoryname)[Trello Story](https://trello.com/c/z2zOvXD5/53-bugfix-groupoffer-index-groupoffercategory-filter-shows-id-instead-of-categoryname)https://git.panter.ch/open-source/aoz-003/-/merge_requests/424Resolve "Hour Records can be inconsistent (have no hourable relation)"2018-01-16T11:33:48+01:00Kaspar Vollenweidervok@panter.chResolve "Hour Records can be inconsistent (have no hourable relation)"Closes #375Closes #375Tugce Nur TasTugce Nur Tashttps://git.panter.ch/open-source/aoz-003/-/merge_requests/798Resolve "reminder_mailing show crashes if reminder mailing has no reminder_ma...2018-07-16T13:40:06+02:00Kaspar Vollenweidervok@panter.chResolve "reminder_mailing show crashes if reminder mailing has no reminder_mailing_volunteer records"Closes #438
https://trello.com/c/HlvqxO8L/197-bug-remindermailing-show-crashes-if-reminder-mailing-has-no-remindermailingvolunteer-records
https://aoz-freiwillige.ch/reminder_mailings/8
View crashes because it tries to run metho...Closes #438
https://trello.com/c/HlvqxO8L/197-bug-remindermailing-show-crashes-if-reminder-mailing-has-no-remindermailingvolunteer-records
https://aoz-freiwillige.ch/reminder_mailings/8
View crashes because it tries to run method on nil here:
```
@reminder_mailing.reminder_mailing_volunteers.select(&:picked?).sample.process_template
```
[show.html.slim Line 20](https://git.panter.ch/open-source/aoz-003/blob/develop/app/views/reminder_mailings/show.html.slim#L20)
```
I, [2018-07-06T18:25:58.880003 #23560] INFO -- : [28c90307-e98f-4843-9591-7dd26281ad9a] Rendered reminder_mailings/show.html.slim within layouts/application (6.3ms)
I, [2018-07-06T18:25:58.880348 #23560] INFO -- : [28c90307-e98f-4843-9591-7dd26281ad9a] Completed 500 Internal Server Error in 21ms (ActiveRecord: 2.7ms)
F, [2018-07-06T18:25:58.881603 #23560] FATAL -- : [28c90307-e98f-4843-9591-7dd26281ad9a]
F, [2018-07-06T18:25:58.881755 #23560] FATAL -- : [28c90307-e98f-4843-9591-7dd26281ad9a] ActionView::Template::Error (undefined method `process_template' for nil:NilClass):
F, [2018-07-06T18:25:58.882066 #23560] FATAL -- : [28c90307-e98f-4843-9591-7dd26281ad9a] 17: hr
[28c90307-e98f-4843-9591-7dd26281ad9a] 18:
[28c90307-e98f-4843-9591-7dd26281ad9a] 19: h3 Email Beispiel
[28c90307-e98f-4843-9591-7dd26281ad9a] 20: - example = @reminder_mailing.reminder_mailing_volunteers.select(&:picked?).sample.process_template
[28c90307-e98f-4843-9591-7dd26281ad9a] 21: h4 Betreff
[28c90307-e98f-4843-9591-7dd26281ad9a] 22: .mailing-body-preview= example[:subject]
[28c90307-e98f-4843-9591-7dd26281ad9a] 23: h4 Text
F, [2018-07-06T18:25:58.882265 #23560] FATAL -- : [28c90307-e98f-4843-9591-7dd26281ad9a]
F, [2018-07-06T18:25:58.882402 #23560] FATAL -- : [28c90307-e98f-4843-9591-7dd26281ad9a] app/views/reminder_mailings/show.html.slim:20:in `_app_views_reminder_mailings_show_html_slim___2746330942469394029_70322003135560'
```Kaspar Vollenweidervok@panter.chKaspar Vollenweidervok@panter.chhttps://git.panter.ch/open-source/aoz-003/-/merge_requests/796Resolve "FW soll feedback welches von einem superadmin erfasst wurde bearbeit...2018-07-16T09:22:51+02:00Kaspar Vollenweidervok@panter.chResolve "FW soll feedback welches von einem superadmin erfasst wurde bearbeiten können auf last_submitted_hours_and_feedbacks"Closes #437
https://trello.com/c/bSN77Yst/200-bug-fw-soll-feedback-welches-von-einem-superadmin-erfasst-wurde-bearbeiten-können-auf-lastsubmittedhoursandfeedbacks
https://staging.aoz-freiwillige.ch/assignments/215/last_submitted_ho...Closes #437
https://trello.com/c/bSN77Yst/200-bug-fw-soll-feedback-welches-von-einem-superadmin-erfasst-wurde-bearbeiten-können-auf-lastsubmittedhoursandfeedbacks
https://staging.aoz-freiwillige.ch/assignments/215/last_submitted_hours_and_feedbacksKaspar Vollenweidervok@panter.chKaspar Vollenweidervok@panter.chhttps://git.panter.ch/open-source/aoz-003/-/merge_requests/790Resolve "FW fehlt Berechtigung seine eigene Beendigungsfeedback Link einzusehen"2018-07-09T15:59:39+02:00Kaspar Vollenweidervok@panter.chResolve "FW fehlt Berechtigung seine eigene Beendigungsfeedback Link einzusehen"Closes #432
https://trello.com/c/U4TTEQ3v/193-bug-fw-fehlt-berechtigung-seine-eigene-beendigungsfeedback-link-einzusehenCloses #432
https://trello.com/c/U4TTEQ3v/193-bug-fw-fehlt-berechtigung-seine-eigene-beendigungsfeedback-link-einzusehenKaspar Vollenweidervok@panter.chKaspar Vollenweidervok@panter.chhttps://git.panter.ch/open-source/aoz-003/-/merge_requests/786Fix/some browser will only trigger on change on checkbox and not input2018-07-05T19:56:39+02:00Kaspar Vollenweidervok@panter.chFix/some browser will only trigger on change on checkbox and not inputKaspar Vollenweidervok@panter.chKaspar Vollenweidervok@panter.chhttps://git.panter.ch/open-source/aoz-003/-/merge_requests/779Resolve "Same billing expense is shown twice"2018-07-04T11:51:34+02:00Kaspar Vollenweidervok@panter.chResolve "Same billing expense is shown twice"Closes #426
https://trello.com/c/YR4gI8O2/164-same-billing-expense-is-shown-twiceCloses #426
https://trello.com/c/YR4gI8O2/164-same-billing-expense-is-shown-twiceKaspar Vollenweidervok@panter.chKaspar Vollenweidervok@panter.chhttps://git.panter.ch/open-source/aoz-003/-/merge_requests/778Resolve "Als Admin und FW möchte ich bisher erfasstes Feedback auf der last_s...2018-07-04T11:54:50+02:00Kaspar Vollenweidervok@panter.chResolve "Als Admin und FW möchte ich bisher erfasstes Feedback auf der last_submitted_hours_and_feedback einsehen"Closes #425
https://trello.com/c/50MqBglQ
https://staging.aoz-freiwillige.ch/assignments/213/last_submitted_hours_and_feedbacks?redirect_to=%2Freminder_mailings%2F7Closes #425
https://trello.com/c/50MqBglQ
https://staging.aoz-freiwillige.ch/assignments/213/last_submitted_hours_and_feedbacks?redirect_to=%2Freminder_mailings%2F7Kaspar Vollenweidervok@panter.chKaspar Vollenweidervok@panter.chhttps://git.panter.ch/open-source/aoz-003/-/merge_requests/705Resolve "missing Group offer Creator for dropdown in form and @q for invalid ...2018-05-16T16:48:47+02:00Kaspar Vollenweidervok@panter.chResolve "missing Group offer Creator for dropdown in form and @q for invalid form `render :edit`"Closes #409
https://trello.com/c/TBI0CWRC/241-group-offer-update-crashesCloses #409
https://trello.com/c/TBI0CWRC/241-group-offer-update-crashesKaspar Vollenweidervok@panter.chKaspar Vollenweidervok@panter.chhttps://git.panter.ch/open-source/aoz-003/-/merge_requests/682Fix callback skipping in import2018-05-14T15:37:14+02:00Markus Kollermarkus-koller@gmx.chFix callback skipping in importFixes a bug introduced in https://git.panter.ch/open-source/aoz-003/merge_requests/675Fixes a bug introduced in https://git.panter.ch/open-source/aoz-003/merge_requests/675https://git.panter.ch/open-source/aoz-003/-/merge_requests/679Resolve "Fix: Family member import only imports one family member"2018-05-14T17:37:17+02:00Kaspar Vollenweidervok@panter.chResolve "Fix: Family member import only imports one family member"Closes #402
https://trello.com/c/Ku7eGN9l/202-2h-fix-family-member-import-only-imports-one-family-memberCloses #402
https://trello.com/c/Ku7eGN9l/202-2h-fix-family-member-import-only-imports-one-family-memberKaspar Vollenweidervok@panter.chKaspar Vollenweidervok@panter.chhttps://git.panter.ch/open-source/aoz-003/-/merge_requests/678Resolve "Fix: Beruf importieren von tbl_HauptPersonen"2018-05-15T13:53:58+02:00Kaspar Vollenweidervok@panter.chResolve "Fix: Beruf importieren von tbl_HauptPersonen"Closes #401
https://trello.com/c/35qA4ipn/198-1h-fix-beruf-importieren-von-tblhauptpersonen
Closes #401
https://trello.com/c/35qA4ipn/198-1h-fix-beruf-importieren-von-tblhauptpersonen
Kaspar Vollenweidervok@panter.chKaspar Vollenweidervok@panter.chhttps://git.panter.ch/open-source/aoz-003/-/merge_requests/677Resolve "Fix: Catch invalid country two letter code in nationality_name(natio...2018-05-14T13:38:06+02:00Kaspar Vollenweidervok@panter.chResolve "Fix: Catch invalid country two letter code in nationality_name(nationality) method"Closes #400
https://trello.com/c/9Dclg1a9/229-bugfix-nationalityname-helper-crashCloses #400
https://trello.com/c/9Dclg1a9/229-bugfix-nationalityname-helper-crashKaspar Vollenweidervok@panter.chKaspar Vollenweidervok@panter.ch