aoz-003 merge requestshttps://git.panter.ch/open-source/aoz-003/-/merge_requests2018-01-23T08:25:54+01:00https://git.panter.ch/open-source/aoz-003/-/merge_requests/425WIP: Resolve "Gitlab CI doesn't cache bundler"2018-01-23T08:25:54+01:00Kaspar Vollenweidervok@panter.chWIP: Resolve "Gitlab CI doesn't cache bundler"Closes #376Closes #376https://git.panter.ch/open-source/aoz-003/-/merge_requests/445WIP: Do not show beendete / quittierte / ... assignement on assignement main ...2018-01-30T16:16:38+01:00Kaspar Vollenweidervok@panter.chWIP: Do not show beendete / quittierte / ... assignement on assignement main index[Trello Story](https://trello.com/c/eV5mIm5k/50-do-not-show-beendete-quittierte-assignement-on-assignement-main-index)
[Trello Story](https://trello.com/c/eV5mIm5k/50-do-not-show-beendete-quittierte-assignement-on-assignement-main-index)
https://git.panter.ch/open-source/aoz-003/-/merge_requests/521WIP: Bugs with group assignment fields2018-03-20T20:36:42+01:00Markus Kollermarkus-koller@gmx.chWIP: Bugs with group assignment fieldshttps://trello.com/c/6CJ84kRU/34-3-not-priority-for-this-sprintbug-groupassignment-edithttps://trello.com/c/6CJ84kRU/34-3-not-priority-for-this-sprintbug-groupassignment-editMarkus Kollermarkus-koller@gmx.chMarkus Kollermarkus-koller@gmx.chhttps://git.panter.ch/open-source/aoz-003/-/merge_requests/592bugfix/Spesen#Index crashing2018-04-04T15:12:09+02:00Tugce Nur Tasbugfix/Spesen#Index crashing[Trello Story](https://trello.com/c/YEVtO6Pa/151-bug-neue-spesenindex-crashed-auf-staging)
https://staging.aoz-freiwillige.ch/billing_expenses
**ActionView::Template::Error (Object must be a Date, DateTime or Time object. nil given.):*...[Trello Story](https://trello.com/c/YEVtO6Pa/151-bug-neue-spesenindex-crashed-auf-staging)
https://staging.aoz-freiwillige.ch/billing_expenses
**ActionView::Template::Error (Object must be a Date, DateTime or Time object. nil given.):**
```
ActionView::Template::Error (Object must be a Date, DateTime or Time object. nil given.):
F, [2018-04-04T14:17:49.416928 #21472] FATAL -- : [c101d7d6-5e80-49b5-9d11-29e774eeab31] 41: td= record.full_bank_details
[c101d7d6-5e80-49b5-9d11-29e774eeab31] 42: td= link_to format_hours(record.hours.total_hours), volunteer_hours_path(record.volunteer)
[c101d7d6-5e80-49b5-9d11-29e774eeab31] 43: td= format_currency record.amount
[c101d7d6-5e80-49b5-9d11-29e774eeab31] 44: td= format_hours_period record.hours
[c101d7d6-5e80-49b5-9d11-29e774eeab31] 45: td= link_to record.user, profile_link(record.user)
[c101d7d6-5e80-49b5-9d11-29e774eeab31] 46: td= l(record.created_at.to_date)
[c101d7d6-5e80-49b5-9d11-29e774eeab31] 47:
F, [2018-04-04T14:17:49.417203 #21472] FATAL -- : [c101d7d6-5e80-49b5-9d11-29e774eeab31]
F, [2018-04-04T14:17:49.417374 #21472] FATAL -- : [c101d7d6-5e80-49b5-9d11-29e774eeab31] app/helpers/format_helper.rb:13:in `format_hours_period'
[c101d7d6-5e80-49b5-9d11-29e774eeab31] app/views/billing_expenses/index.html.slim:44:in `block in _app_views_billing_expenses_index_html_slim___2103386005377330170_47453746246920'
[c101d7d6-5e80-49b5-9d11-29e774eeab31] app/views/billing_expenses/index.html.slim:31:in `_app_views_billing_expenses_index_html_slim___2103386005377330170_47453746246920'
```https://git.panter.ch/open-source/aoz-003/-/merge_requests/602fix clients index if there is no relation for family memberz2018-04-20T13:35:01+02:00Tugce Nur Tasfix clients index if there is no relation for family memberzclients index was crashing if there was no relation givenclients index was crashing if there was no relation givenhttps://git.panter.ch/open-source/aoz-003/-/merge_requests/655WIP: Resolve "BUG: Assignments Index Inaktiv Filter crashes"2018-05-08T10:22:56+02:00Kaspar Vollenweidervok@panter.chWIP: Resolve "BUG: Assignments Index Inaktiv Filter crashes"Closes #391Closes #391https://git.panter.ch/open-source/aoz-003/-/merge_requests/656WIP: Resolve "Assignment active? method is not the same as filter result"2018-05-11T14:38:19+02:00Kaspar Vollenweidervok@panter.chWIP: Resolve "Assignment active? method is not the same as filter result"Closes #392
## reasons
- The index views active filter uses the scope [active_or_not_yet_active](app/models/concerns/period_start_end_scopes_and_methods.rb#L37)
- So the scope filters for assignments that are not returning true...Closes #392
## reasons
- The index views active filter uses the scope [active_or_not_yet_active](app/models/concerns/period_start_end_scopes_and_methods.rb#L37)
- So the scope filters for assignments that are not returning true on `assignment.active?` beeing used within the [assignment_status_badge helper](app/helpers/navigation_and_button_helper.rb#L75)
So this is rather a inconsistency between filter and view logic.
## Description
https://trello.com/c/ZFfaGbLX/99-1h-filter-aktiv-inaktiv-funktioniert-nicht
https://staging.aoz-freiwillige.ch/assignments?q%5Bactive_or_not_yet_active%5D=true
The following inactive Assignement is shown: https://staging.aoz-freiwillige.ch/assignments/913/edit
![ActiveInactiveBadgeIsWrong](/uploads/0f9de1d17aec8ccfb514de045d5876ea/ActiveInactiveBadgeIsWrong.jpg)Kaspar Vollenweidervok@panter.chKaspar Vollenweidervok@panter.chhttps://git.panter.ch/open-source/aoz-003/-/merge_requests/684WIP: Resolve "Bug: Imported Volunteers can have empty salutations (in rare ca...2018-05-15T11:10:59+02:00Kaspar Vollenweidervok@panter.chWIP: Resolve "Bug: Imported Volunteers can have empty salutations (in rare cases, 5 out of 276)"Closes #405
https://trello.com/c/oFR89gDJ/231-bug-imported-volunteers-can-have-empty-salutations-in-rare-cases-5-out-of-276
Closes #405
https://trello.com/c/oFR89gDJ/231-bug-imported-volunteers-can-have-empty-salutations-in-rare-cases-5-out-of-276
Kaspar Vollenweidervok@panter.chKaspar Vollenweidervok@panter.chhttps://git.panter.ch/open-source/aoz-003/-/merge_requests/716WIP: Resolve "Don't show 'Beendete Einsätze' Button for Department Manager"2018-05-18T10:37:43+02:00Kaspar Vollenweidervok@panter.chWIP: Resolve "Don't show 'Beendete Einsätze' Button for Department Manager"Closes #413
https://trello.com/c/W8R8Nljd/246-dont-show-beendete-eins%C3%A4tze-button-for-department-managerCloses #413
https://trello.com/c/W8R8Nljd/246-dont-show-beendete-eins%C3%A4tze-button-for-department-managerKaspar Vollenweidervok@panter.chKaspar Vollenweidervok@panter.ch