aoz-003 merge requestshttps://git.panter.ch/open-source/aoz-003/-/merge_requests2017-07-12T13:36:09+02:00https://git.panter.ch/open-source/aoz-003/-/merge_requests/101fix the not working and obsolete full_name concern2017-07-12T13:36:09+02:00Kaspar Vollenweidervok@panter.chfix the not working and obsolete full_name concernThis concern was actually only working in the Relatives model as is:
```ruby
def full_name
"#{first_name} #{last_name}"
end
```
In User and Volunteer, it could only crash the app, because:
```ruby
@user.profile.contact.firs...This concern was actually only working in the Relatives model as is:
```ruby
def full_name
"#{first_name} #{last_name}"
end
```
In User and Volunteer, it could only crash the app, because:
```ruby
@user.profile.contact.first_name
@volunteer.contact.first_name
@relative.first_name
```
And, it was included into Volunteer as this, and it only didn't crash everything, because it was never used inside the Volunteer model. So remove it from Volunteer and put the working method to User and Relative.
Or in other words: **it was rather a bug, then a concern** ;)https://git.panter.ch/open-source/aoz-003/-/merge_requests/99fixing wrong path for user profile in departments2017-07-12T13:36:23+02:00Kaspar Vollenweidervok@panter.chfixing wrong path for user profile in departmentsIt was a quite mean bug because it doesn't bang in most cases.
Why:
Profile and User are almost always saved together. So on a fresh DB they will also almost always turn out to have the same `id`. Almost... ;)
And that's wat was not t...It was a quite mean bug because it doesn't bang in most cases.
Why:
Profile and User are almost always saved together. So on a fresh DB they will also almost always turn out to have the same `id`. Almost... ;)
And that's wat was not the case on the staging server, so linking like that didn't work there, but on our dev machines, it did.https://git.panter.ch/open-source/aoz-003/-/merge_requests/133Issue #132: Fix/policy completation and debugging trying to deal with2017-08-03T11:10:21+02:00Kaspar Vollenweidervok@panter.chIssue #132: Fix/policy completation and debugging trying to deal with# [Story in Trello](https://trello.com/c/XPhS9Uyw/57-fix-wrong-placement-of-device-authorizing-in-controllers-and-extend-policies-to-cover-all-controllers-and-actions-as-needed-devi)
## Done?
### Done for approval?
* [x] Accepta...# [Story in Trello](https://trello.com/c/XPhS9Uyw/57-fix-wrong-placement-of-device-authorizing-in-controllers-and-extend-policies-to-cover-all-controllers-and-actions-as-needed-devi)
## Done?
### Done for approval?
* [x] Acceptance criteria are met
* [x] Code quality checks are green
* [x] Readme updated if needed
* [x] Story under test
* [x] Mobile works
* [x] Seeds created
* [ ] Translated
* [ ] Code is reviewed
### Done after the merge?
* [ ] Deployed to staging after the merge
* [ ] Tested manually on staging
Kaspar Vollenweidervok@panter.chKaspar Vollenweidervok@panter.chhttps://git.panter.ch/open-source/aoz-003/-/merge_requests/424Resolve "Hour Records can be inconsistent (have no hourable relation)"2018-01-16T11:33:48+01:00Kaspar Vollenweidervok@panter.chResolve "Hour Records can be inconsistent (have no hourable relation)"Closes #375Closes #375Tugce Nur TasTugce Nur Tashttps://git.panter.ch/open-source/aoz-003/-/merge_requests/440fixes/group offer department label2018-01-18T16:43:22+01:00Tugce Nur Tasfixes/group offer department labelKaspar Vollenweidervok@panter.chKaspar Vollenweidervok@panter.chhttps://git.panter.ch/open-source/aoz-003/-/merge_requests/441BugFix - list_responses/feedback2018-01-18T18:40:43+01:00Kaspar Vollenweidervok@panter.chBugFix - list_responses/feedback[Trello Story](https://trello.com/c/7PGG3Zle/43-bug-listresponses-feedback)[Trello Story](https://trello.com/c/7PGG3Zle/43-bug-listresponses-feedback)https://git.panter.ch/open-source/aoz-003/-/merge_requests/443Fixes/group offer no start date crashes on reminder creation2018-01-18T20:15:47+01:00Kaspar Vollenweidervok@panter.chFixes/group offer no start date crashes on reminder creation[Trello Story](https://trello.com/c/IKTOkBQs/46-bug-creating-a-halfyearreminder-for-groupoffers-can-crash-because-there-are-also-groupoffers-in-the-selection-which-have-no-star)[Trello Story](https://trello.com/c/IKTOkBQs/46-bug-creating-a-halfyearreminder-for-groupoffers-can-crash-because-there-are-also-groupoffers-in-the-selection-which-have-no-star)https://git.panter.ch/open-source/aoz-003/-/merge_requests/436Fixes: Group Offers and Department Manager2018-01-19T11:13:24+01:00Ghost UserFixes: Group Offers and Department ManagerStory in [trello](https://trello.com/c/XJBStWLo/40-bugfix-if-the-department-manager-who-is-responsible-for-a-group-offer-has-no-department-they-cannot-edit-view-their-group-offer)
If the department manager who is responsible for a gro...Story in [trello](https://trello.com/c/XJBStWLo/40-bugfix-if-the-department-manager-who-is-responsible-for-a-group-offer-has-no-department-they-cannot-edit-view-their-group-offer)
If the department manager who is responsible for a group offer has no department, they cannot edit/view their group offerhttps://git.panter.ch/open-source/aoz-003/-/merge_requests/444Fixes: tandem-quittiert-filter-available-only-to-superadmin2018-01-19T16:14:39+01:00Ghost UserFixes: tandem-quittiert-filter-available-only-to-superadmin[Trello story](https://trello.com/c/xl2eRvbX/51-tandem-quittiert-filter-available-only-to-superadmin)
Tandem Quittieren is done only by superadmins.
So the corresponding filter should be available only to them.[Trello story](https://trello.com/c/xl2eRvbX/51-tandem-quittiert-filter-available-only-to-superadmin)
Tandem Quittieren is done only by superadmins.
So the corresponding filter should be available only to them.https://git.panter.ch/open-source/aoz-003/-/merge_requests/442Fixes/dossier2018-01-19T16:38:44+01:00Ghost UserFixes/dossier[Trello story](https://trello.com/c/dLJaFLnA/45-tandem-still-appears-twice-at-dossier-show-and-other-fixes)
Fix Tandem appearing twice in edit/show/download view and test.
Add missing glyphicons for back.
Remove color from del...[Trello story](https://trello.com/c/dLJaFLnA/45-tandem-still-appears-twice-at-dossier-show-and-other-fixes)
Fix Tandem appearing twice in edit/show/download view and test.
Add missing glyphicons for back.
Remove color from delete button.
Replace delete icon with word.
Other changes.https://git.panter.ch/open-source/aoz-003/-/merge_requests/451Bugfix/group offer category filter shows id instead of group offer category name2018-01-23T15:31:04+01:00Kaspar Vollenweidervok@panter.chBugfix/group offer category filter shows id instead of group offer category name[Trello Story](https://trello.com/c/z2zOvXD5/53-bugfix-groupoffer-index-groupoffercategory-filter-shows-id-instead-of-categoryname)[Trello Story](https://trello.com/c/z2zOvXD5/53-bugfix-groupoffer-index-groupoffercategory-filter-shows-id-instead-of-categoryname)https://git.panter.ch/open-source/aoz-003/-/merge_requests/472Fixes/group assignment fixes2018-02-02T17:17:31+01:00Tugce Nur TasFixes/group assignment fixes[Trello Story](https://trello.com/c/bKnnULYC/70-bug-group-offers-show-crashing-on-staging)
## Fixes
* [x] fixed group offer view
* [x] added ended Assignments and GroupAssignments to Seeds
* [x] added timestamps for GroupAssignments...[Trello Story](https://trello.com/c/bKnnULYC/70-bug-group-offers-show-crashing-on-staging)
## Fixes
* [x] fixed group offer view
* [x] added ended Assignments and GroupAssignments to Seeds
* [x] added timestamps for GroupAssignments
* [x] some small nitpicking on seed comments
## Process
* [x] reviewedhttps://git.panter.ch/open-source/aoz-003/-/merge_requests/473fix migration null:true for deployment2018-02-06T09:52:16+01:00Tugce Nur Tasfix migration null:true for deploymenthttps://git.panter.ch/open-source/aoz-003/-/merge_requests/508Bug: volunteer can have many events2018-03-03T10:26:56+01:00Tugce Nur TasBug: volunteer can have many events[Trello Story](https://trello.com/c/FAVWKC5N/66-bug-volunteer-can-have-many-events)[Trello Story](https://trello.com/c/FAVWKC5N/66-bug-volunteer-can-have-many-events)https://git.panter.ch/open-source/aoz-003/-/merge_requests/512Bugfixes/client acceptance show2018-03-07T17:23:24+01:00Tugce Nur TasBugfixes/client acceptance showDie Affirmation bei der Ansicht des Klienten wurde noch in Englisch angezeigt.
[Trello Story](https://trello.com/c/EC36OtWa/73-bugfixes-client-acceptance-show)Die Affirmation bei der Ansicht des Klienten wurde noch in Englisch angezeigt.
[Trello Story](https://trello.com/c/EC36OtWa/73-bugfixes-client-acceptance-show)https://git.panter.ch/open-source/aoz-003/-/merge_requests/515Fix seeds2018-03-09T20:16:52+01:00Markus Kollermarkus-koller@gmx.chFix seedsI broke the seeds in !510 because `FFaker::Time.between` doesn't work with dates.I broke the seeds in !510 because `FFaker::Time.between` doesn't work with dates.https://git.panter.ch/open-source/aoz-003/-/merge_requests/516Fix import of Selectize Bootstrap theme2018-03-09T20:17:01+01:00Markus Kollermarkus-koller@gmx.chFix import of Selectize Bootstrap themehttps://trello.com/c/dKvXkGYU/44-selectize-not-properly-working-on-staging
The problem was the `.css`, the actual file has `.scss` as extension and for some reason this didn't break in `develop`.
But the extension is optional anyway, th...https://trello.com/c/dKvXkGYU/44-selectize-not-properly-working-on-staging
The problem was the `.css`, the actual file has `.scss` as extension and for some reason this didn't break in `develop`.
But the extension is optional anyway, the asset pipeline already handles this.
I did a test deploy to staging (by changing the branch locally in `config/deploy/staging.rb`) and it seems to work fine now, see e.g. https://staging.aoz-freiwillige.ch/events/4. On the intro course events the dropdown is empty because `Volunteer.needs_intro_course` is currently empty.https://git.panter.ch/open-source/aoz-003/-/merge_requests/517Bugfixes/created by translation volunteer show2018-03-13T13:39:42+01:00Tugce Nur TasBugfixes/created by translation volunteer show[Trello Story](https://trello.com/c/KQ0dghVc/53-fw-show-translation-registered-by)
Auf der Freiwilligen Ansicht wurde "Angemeldet durch" noch auf englisch angezeigt.[Trello Story](https://trello.com/c/KQ0dghVc/53-fw-show-translation-registered-by)
Auf der Freiwilligen Ansicht wurde "Angemeldet durch" noch auf englisch angezeigt.https://git.panter.ch/open-source/aoz-003/-/merge_requests/524Prefill email field when creating profile2018-03-13T16:46:18+01:00Markus Kollermarkus-koller@gmx.chPrefill email field when creating profilehttps://trello.com/c/DA3i21xp/18-wenn-ein-user-sich-durch-die-einladungsmail-zum-ersten-mal-einloggt-sollte-man-nicht-mehr-die-e-mail-adresse-wieder-eintragen-m%C3%BChttps://trello.com/c/DA3i21xp/18-wenn-ein-user-sich-durch-die-einladungsmail-zum-ersten-mal-einloggt-sollte-man-nicht-mehr-die-e-mail-adresse-wieder-eintragen-m%C3%BChttps://git.panter.ch/open-source/aoz-003/-/merge_requests/522Change button text to invite imported volunteer2018-03-13T16:46:30+01:00Markus Kollermarkus-koller@gmx.chChange button text to invite imported volunteerhttps://trello.com/c/BzdTWGXv/39-importierten-fw-einladen-auf-fw-profilhttps://trello.com/c/BzdTWGXv/39-importierten-fw-einladen-auf-fw-profil